ijuma commented on code in PR #18321:
URL: https://github.com/apache/kafka/pull/18321#discussion_r1909030619
##########
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##########
@@ -3662,14 +3673,9 @@ class UnifiedLogTest {
assertTrue(newDir.exists())
log.renameDir(newDir.getName, false)
- assertTrue(log.leaderEpochCache.isEmpty)
+ assertFalse(log.leaderEpochCache.nonEmpty)
assertTrue(log.partitionMetadataFile.isEmpty)
assertEquals(0, log.logEndOffset)
- // verify that records appending can still succeed
- // even with the uninitialized leaderEpochCache and partitionMetadataFile
Review Comment:
We don't support appending with the uninitialized leaderEpochCache anymore -
it was questionable to support this after `renameDir(reinitialize=false)` since
the former is invoked as part of the deletion of the log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
