ppkarwasz commented on PR #18472: URL: https://github.com/apache/kafka/pull/18472#issuecomment-2582098975
Similarly to apache/eventmesh#4700, I think that: - Not only `log4j-1.2-api`, but also `log4j-slf4j-impl` should be removed from the runtime dependencies of all artifacts. - `log4j-core` should be an **optional** runtime dependency in `kafka_2_13` and `connect-runtime`. - I am not sure if `log4j-api` should be a direct dependency at all: you only use it in `kafka_2_13` and `connect-runtime`, because you call `log4j-core` methods that have `log4j-api` types in the signature. IMHO it is OK to remove `log4j-api` and rely on the fact the `log4j-core` depends on `log4j-api`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
