cmccabe commented on code in PR #18148:
URL: https://github.com/apache/kafka/pull/18148#discussion_r1911575014
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -352,6 +367,71 @@ private ApiError validateAlterConfig(
return ApiError.NONE;
}
+ List<ApiMessageAndVersion>
maybeTriggerPartitionUpdateOnMinIsrChange(List<ApiMessageAndVersion> records) {
Review Comment:
As we discussed before, this will generate way too many records to be
practical in many cases.
Rather than doing this, how about having a new record type that clears the
ELRs of all partitions? Then we can have the controller generate that whenever
the cluster-level min.insync.replicas is changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
