jolshan commented on code in PR #18486:
URL: https://github.com/apache/kafka/pull/18486#discussion_r1911633047
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##########
@@ -462,17 +462,10 @@ private boolean maybeSendAndPollTransactionalRequest() {
return true;
}
- if (transactionManager.hasAbortableError() ||
transactionManager.isAborting()) {
- if (accumulator.hasIncomplete()) {
Review Comment:
Do we still want to include the accumulator.hasIncomplete check around the
two other statements? I suppose they will just be a no-op if there aren't
incomplete batches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
