mjsax commented on code in PR #18490:
URL: https://github.com/apache/kafka/pull/18490#discussion_r1911865862
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBufferTest.java:
##########
@@ -62,18 +62,16 @@ public class RocksDBTimeOrderedKeyValueBufferTest {
@SuppressWarnings({"rawtypes", "unchecked"})
@BeforeEach
public void setUp() {
- when(serdeGetter.keySerde()).thenReturn((Serde) new
Serdes.StringSerde());
- when(serdeGetter.valueSerde()).thenReturn((Serde) new
Serdes.StringSerde());
final Metrics metrics = new Metrics();
offset = 0;
streamsMetrics = new StreamsMetricsImpl(metrics, "test-client",
"processId", new MockTime());
context = new
MockInternalProcessorContext<>(StreamsTestUtils.getStreamsConfig(), new
TaskId(0, 0), TestUtils.tempDirectory());
}
- private void createBuffer(final Duration grace) {
+ private void createBuffer(final Duration grace, final Serde<String> serde)
{
Review Comment:
"randomizing" this test, to cover both code path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
