chenyulin0719 commented on code in PR #18475:
URL: https://github.com/apache/kafka/pull/18475#discussion_r1911932363
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java:
##########
@@ -167,6 +169,8 @@ private PendingFetchCommittedRequest(final
Set<TopicPartition> requestedPartitio
@Override
public NetworkClientDelegate.PollResult poll(final long currentTimeMs) {
// Copy the outgoing request list and clear it.
+ maybeRetryListOffsetsRequests(false);
Review Comment:
> Besides, I think we should call metadata.requestUpdate right after calling
requestsToRetry.add(listOffsetsRequestState). So it will be blow, instead of
the one in completeExceptionally.
A comment to fix my previous statement:
We don't need to trigger metadata update for StaleMetadataException becasue
it has already handled in `OffsetsRequestManager#groupListOffsetRequests`:
-
https://github.com/apache/kafka/blob/cd061c8039d615f6584eab522c19b407317ba031/clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java#L899-L902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
