lucasbru commented on code in PR #18231:
URL: https://github.com/apache/kafka/pull/18231#discussion_r1912749627
##########
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java:
##########
@@ -205,23 +206,23 @@ private void printMembers(StreamsGroupDescription
description, boolean verbose)
System.out.printf(fmt, "GROUP", "MEMBER", "PROCESS",
"CLIENT-ID", "ACTIVE-TASKS", "STANDBY-TASKS", "WARMUP-TASKS");
for (StreamsGroupMemberDescription member : members) {
System.out.printf(fmt, description.groupId(),
member.memberId(), member.processId(), member.clientId(),
-
getTopicPartitions(member.assignment().activeTasks()).stream().map(tp ->
tp.topic() + ":" + tp.partition()).collect(Collectors.joining(",")),
-
getTopicPartitions(member.assignment().standbyTasks()).stream().map(tp ->
tp.topic() + ":" + tp.partition()).collect(Collectors.joining(",")),
-
getTopicPartitions(member.assignment().warmupTasks()).stream().map(tp ->
tp.topic() + ":" + tp.partition()).collect(Collectors.joining(",")));
+
member.assignment().activeTasks().stream().map(taskId -> taskId.subtopologyId()
+ ":" + taskId.partitions()).collect(Collectors.joining(",")),
Review Comment:
Not necessarily a unit tests. But I think it would be good to actually run
the tool, even if we do not have an integration test yet. I think if we'd run
it, we'd spot this kind of formatting problems easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
