jsancio commented on code in PR #18389:
URL: https://github.com/apache/kafka/pull/18389#discussion_r1913617063
##########
bin/kafka-storage.sh:
##########
@@ -14,4 +14,12 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+for i in $(seq 1 $#); do
+ if [ "${!i}" = "-c" ] || [ "${!i}" = "--config" ]; then
+ next_i=$((i + 1))
+ [[ "${!next_i}" == *"config/kraft"* ]] && echo "Warning: If using
default properties file, config/kraft path has been deprecated"
Review Comment:
Why is this needed to address the intent of the Jira? It is odd for a script
to be checking the path of a file. The CLI should only be concern with the
content of the file.
##########
bin/kafka-server-start.sh:
##########
@@ -19,6 +19,14 @@ then
echo "USAGE: $0 [-daemon] server.properties [--override
property=value]*"
exit 1
fi
+
+for arg in "$@"; do
+ if [[ "$arg" == *.properties ]]; then
+ [[ "$arg" == *"config/kraft"* ]] && echo "Warning: If using default
properties file, config/kraft path has been deprecated"
+ break
+ fi
+done
Review Comment:
Why is this needed to address the intent of the Jira? It is odd for a script
to be checking the path of a file. The CLI should only be concern with the
content of the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
