mjsax commented on code in PR #18517:
URL: https://github.com/apache/kafka/pull/18517#discussion_r1914225201
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java:
##########
@@ -786,9 +787,11 @@ private static Bytes subscriptionStoreKey(final String
lhs, final String rhs) {
return key;
}
- protected static Map<String, String> asMap(final KeyValueStore<String,
String> store) {
+ protected static Map<String, String> asMap(final KeyValueStore<String,
ValueAndTimestamp<String>> store) {
final HashMap<String, String> result = new HashMap<>();
- store.all().forEachRemaining(kv -> result.put(kv.key, kv.value));
+ try (final KeyValueIterator<String, ValueAndTimestamp<String>> it =
store.all()) {
Review Comment:
Additional side cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
