apoorvmittal10 opened a new pull request, #18524: URL: https://github.com/apache/kafka/pull/18524
As per the discussion with @ijuma and @mumrah, the `share` module seems not required and it's advised to user `server` and `server-common` instead. The PR moves the classes from `share` module to respective server related modules. Following has been refactored in the PR: - Moved Share Fetch, Acknowledge, Session, Context and Cache related classes to `server` module as the classes are used by `core` and `tools` modules. - Moved `Persister` releated classes from `share` to `server-common` as the Persister classes though currently just being used by `core` module but in [near future](https://github.com/apache/kafka/pull/17775) will also be used by `group-coordinator`. If Persister related classes are added to `server` then it will create cyclic dependency, `server` alredy requires `group-coordinator` hence `group-coordinator` cannot have dependency on `server`, hence leveraged the existing `server-common` which already exists as dependency in `group-coordinator`. - Updated build.gradle to remove `share` module. - Removed `import-control-share.xml` ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
