apoorvmittal10 commented on code in PR #18459:
URL: https://github.com/apache/kafka/pull/18459#discussion_r1915209071
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -627,9 +628,8 @@ public ShareAcquiredRecords acquire(
if (subMap.isEmpty()) {
log.trace("No cached data exists for the share partition for
requested fetch batch: {}-{}",
groupId, topicIdPartition);
- AcquiredRecords acquiredRecords =
acquireNewBatchRecords(memberId, fetchPartitionData.records.batches(),
- firstBatch.baseOffset(), lastBatch.lastOffset(),
maxFetchRecords);
- return
ShareAcquiredRecords.fromAcquiredRecords(acquiredRecords);
+ return acquireNewBatchRecords(memberId,
fetchPartitionData.records.batches(),
Review Comment:
Created: https://issues.apache.org/jira/browse/KAFKA-18522. I ll adjust the
fetch records batches in response accordingly.
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -244,13 +244,14 @@ public CompletableFuture<Map<TopicIdPartition,
PartitionData>> fetchMessages(
String groupId,
String memberId,
FetchParams fetchParams,
+ int batchSize,
Review Comment:
My bad, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
