[ 
https://issues.apache.org/jira/browse/KAFKA-18517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912982#comment-17912982
 ] 

Lianet Magrans commented on KAFKA-18517:
----------------------------------------

Hey, thanks for taking a look. We definitely have to make sure that whatever is 
running for the CLASSIC only, is indeed related to something that is not 
supported for the new consumer/protocol. (ie. tests related to client-side 
assignors are supposed to run only for classic 
[https://github.com/apache/kafka/blob/81938eb0864436bce63aadfd0fb3fdfe0bc71779/core/src/test/scala/integration/kafka/api/PlaintextConsumerAssignorsTest.scala#L36-L39]
 )

Other than that, whatever we find that should run for both and it's not, we 
should attempt to enable it (I just opened a PR for the ConsumerBounceTest 
btw). Do you want to work on this? I think we should start by triaging those 
you already identify (attempt to run them for both doing any test config change 
required like in the ConsumerBounceTest. If bigger issues arise we file a Jira 
to investigate further). Let me know if you want to take it and I can help (or 
I'll drive the triage if you don't have bandwidth). Thanks!

> ConsumerBounceTest should run for async consumer
> ------------------------------------------------
>
>                 Key: KAFKA-18517
>                 URL: https://issues.apache.org/jira/browse/KAFKA-18517
>             Project: Kafka
>          Issue Type: Test
>          Components: consumer
>            Reporter: Lianet Magrans
>            Assignee: Lianet Magrans
>            Priority: Blocker
>              Labels: kip-848-client-support
>             Fix For: 4.0.0
>
>
> All tests in the file are parametrized to run for Classic only, so they won't 
> run with the new async consumer. We should enabled them so that they run both 
> both consumers.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to