chia7712 commented on code in PR #17390:
URL: https://github.com/apache/kafka/pull/17390#discussion_r1916934443
##########
core/src/main/scala/kafka/log/LogCleanerManager.scala:
##########
@@ -533,21 +533,15 @@ private[log] class LogCleanerManager(val logDirs:
Seq[File],
def maintainUncleanablePartitions(): Unit = {
Review Comment:
ditto. `LogCleanerManagerTest` is a good place :)
##########
core/src/main/scala/kafka/log/LogCleaner.scala:
##########
@@ -116,12 +116,11 @@ class LogCleaner(initialConfig: CleanerConfig,
private[log] val cleaners = mutable.ArrayBuffer[CleanerThread]()
/**
- * scala 2.12 does not support maxOption so we handle the empty manually.
* @param f to compute the result
* @return the max value (int value) or 0 if there is no cleaner
*/
private def maxOverCleanerThreads(f: CleanerThread => Double): Int =
Review Comment:
Maybe we can add a unit test to `LogCleanerTest`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
