chia7712 commented on code in PR #18550:
URL: https://github.com/apache/kafka/pull/18550#discussion_r1917072973
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -2693,18 +2680,10 @@ class KafkaApis(val requestChannel: RequestChannel,
if (!authHelper.authorize(request.context, DESCRIBE_CONFIGS, CLUSTER,
CLUSTER_NAME)) {
requestHelper.sendMaybeThrottle(request,
listClientMetricsResourcesRequest.getErrorResponse(Errors.CLUSTER_AUTHORIZATION_FAILED.exception))
} else {
- clientMetricsManager match {
- case Some(metricsManager) =>
- val data = new
ListClientMetricsResourcesResponseData().setClientMetricsResources(
- metricsManager.listClientMetricsResources.asScala.map(
- name => new ClientMetricsResource().setName(name)).toList.asJava)
- requestHelper.sendMaybeThrottle(request, new
ListClientMetricsResourcesResponse(data))
- case None =>
- // This should never happen as ZK based cluster calls should get
rejected earlier itself,
- // but we should handle it gracefully.
- info("Received list client metrics resources request for zookeeper
based cluster")
- requestHelper.sendMaybeThrottle(request,
listClientMetricsResourcesRequest.getErrorResponse(Errors.UNSUPPORTED_VERSION.exception))
- }
+ val data = new
ListClientMetricsResourcesResponseData().setClientMetricsResources(
+ clientMetricsManager.listClientMetricsResources.stream.map(
+ name => new
ClientMetricsResource().setName(name)).collect(Collectors.toList()))
Review Comment:
nit: `collect(Collectors.toList())` -> `toList`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
