chia7712 commented on code in PR #18483:
URL: https://github.com/apache/kafka/pull/18483#discussion_r1917164317
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -2682,7 +2648,6 @@ class KafkaApis(val requestChannel: RequestChannel,
requestHelper.sendMaybeThrottle(request,
pushTelemetryRequest.getErrorResponse(Errors.INVALID_REQUEST.exception))
}
case None =>
- info("Received push telemetry client request for zookeeper based
cluster")
Review Comment:
ditto
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -2665,7 +2632,6 @@ class KafkaApis(val requestChannel: RequestChannel,
requestHelper.sendMaybeThrottle(request,
subscriptionRequest.getErrorResponse(Errors.INVALID_REQUEST.exception))
}
case None =>
- info("Received get telemetry client request for zookeeper based
cluster")
Review Comment:
Could you please revert this change as it is included by #18550?
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -2700,9 +2665,8 @@ class KafkaApis(val requestChannel: RequestChannel,
name => new ClientMetricsResource().setName(name)).toList.asJava)
requestHelper.sendMaybeThrottle(request, new
ListClientMetricsResourcesResponse(data))
case None =>
- // This should never happen as ZK based cluster calls should get
rejected earlier itself,
+ // This should never happen as based cluster calls should get
rejected earlier itself,
// but we should handle it gracefully.
- info("Received list client metrics resources request for zookeeper
based cluster")
Review Comment:
ditto
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -3120,7 +3083,6 @@ class KafkaApis(val requestChannel: RequestChannel,
case Some(manager) => manager
case None =>
// The API is not supported when the SharePartitionManager is not
defined on the broker
- info("Received share acknowledge request for zookeeper based cluster")
Review Comment:
ditto
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -2800,7 +2764,6 @@ class KafkaApis(val requestChannel: RequestChannel,
case Some(manager) => manager
case None =>
// The API is not supported when the SharePartitionManager is not
defined on the broker
- info("Received share fetch request for zookeeper based cluster")
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
