ahuang98 commented on code in PR #18240:
URL: https://github.com/apache/kafka/pull/18240#discussion_r1917376912
##########
raft/src/test/java/org/apache/kafka/raft/QuorumStateTest.java:
##########
@@ -154,6 +155,163 @@ private ReplicaKey replicaKey(int id, boolean
withDirectoryId) {
return ReplicaKey.of(id, directoryId);
}
+ @ParameterizedTest
Review Comment:
Sorry, I wish github was a bit smarter with diffs :( It was difficult for me
to figure out what coverage we were missing without the tests being more
ordered (and I thought it would be difficult for you to tell what we might be
missing as well) so I ended up deciding the re-order was worth it.
We discussed this briefly before, but ideally each state will have its own
file in the end - I decided not to make that change in this PR since it would
make it even harder to tell what had changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
