mimaison commented on code in PR #18389:
URL: https://github.com/apache/kafka/pull/18389#discussion_r1918732928
##########
bin/kafka-server-start.sh:
##########
@@ -19,6 +19,14 @@ then
echo "USAGE: $0 [-daemon] server.properties [--override
property=value]*"
exit 1
fi
+
+for arg in "$@"; do
+ if [[ "$arg" == *.properties ]]; then
+ [[ "$arg" == *"config/kraft"* ]] && echo "Warning: The 'config/kraft'
path has been removed. Now all configuration files are in 'config'."
Review Comment:
Should the pattern be `*"config/kraft/"*`? Otherwise you get the message
printed if your config file is called `kraft.properties` for example.
If so let's do it in `bin/kafka-storage.sh` too.
I'm actually wondering if we need this warning at all. Users could get this
message if their configuration files are in custom paths. What do the other
committers think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
