ijuma commented on code in PR #18567:
URL: https://github.com/apache/kafka/pull/18567#discussion_r1918760999
##########
server-common/src/main/java/org/apache/kafka/server/config/ConfigType.java:
##########
@@ -31,6 +31,5 @@ public class ConfigType {
public static final String CLIENT_METRICS = "client-metrics";
public static final String GROUP = "groups";
- // Do not include ClientMetrics and Groups in `all` as they are not
supported on ZK.
Review Comment:
I would, in fact, avoid the need for `ConfigCommand` to do its own
definition of the config types the system supports - commands should ideally
not have any such logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
