FrankYang0529 commented on PR #18573:
URL: https://github.com/apache/kafka/pull/18573#issuecomment-2596042457

   > can you describe what the fix was in this case?
   
   Sorry for that. I deleted code in `TopicConfigHandler#updateLogConfig`. We 
should not remove this. We can just fix it by removing last argument in 
`LogManager#updateTopicConfig`.
   
   Before: 
   ```
       // kafkaController is only defined in Zookeeper's mode
       logManager.updateTopicConfig(topic, topicConfig, 
kafkaConfig.remoteLogManagerConfig.isRemoteStorageSystemEnabled(),
         wasRemoteLogEnabled, kafkaController.isDefined)
   ```
   
   After:
   ```
       logManager.updateTopicConfig(topic, topicConfig, 
kafkaConfig.remoteLogManagerConfig.isRemoteStorageSystemEnabled(),
         wasRemoteLogEnabled)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to