frankvicky commented on code in PR #18586:
URL: https://github.com/apache/kafka/pull/18586#discussion_r1920291424
##########
core/src/test/scala/integration/kafka/api/SaslSetup.scala:
##########
Review Comment:
Hi @clolov
> For my understanding, in this PR you basically want to remove ZkSasl and
Both and since this will leave only one enum you make that the default
behaviour and remove KafkaSasl as well?
Yes, you're right.
> In the changed file, are the following lines still needed?
Thanks for pointing out.
I somehow miss these lines. I will update in the next commit.
> def createScramCredentials(zkConnect: String, userName: String, password:
String): Unit = {
...
This is handled by #18585 and it has just been merged. I will rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
