showuon commented on code in PR #18519:
URL: https://github.com/apache/kafka/pull/18519#discussion_r1923649469
##########
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/VerificationKeyResolverFactory.java:
##########
@@ -58,6 +58,7 @@ public static CloseableVerificationKeyResolver
create(Map<String, ?> configs,
String saslMechanism,
Map<String, Object> jaasConfig) {
ConfigurationUtils cu = new ConfigurationUtils(configs, saslMechanism);
+ cu.throwIfURLIsNotAllowed(SASL_OAUTHBEARER_JWKS_ENDPOINT_URL);
Review Comment:
I just thought strictly speaking, `throwIfURLIsNotAllowed` is not part of
url validation. But I don't have strong opinion on it. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]