lianetm commented on code in PR #18532:
URL: https://github.com/apache/kafka/pull/18532#discussion_r1923997408
##########
core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala:
##########
@@ -59,7 +59,12 @@ class ConsumerBounceTest extends AbstractConsumerTest with
Logging {
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG -> "1",
GroupCoordinatorConfig.GROUP_MIN_SESSION_TIMEOUT_MS_CONFIG -> "10", // set
small enough session timeout
GroupCoordinatorConfig.GROUP_INITIAL_REBALANCE_DELAY_MS_CONFIG -> "0",
+
+ // Tests will run for CONSUMER and CLASSIC group protocol, so set the
group max size property
+ // required for each.
+ GroupCoordinatorConfig.CONSUMER_GROUP_MAX_SIZE_CONFIG ->
maxGroupSize.toString,
GroupCoordinatorConfig.GROUP_MAX_SIZE_CONFIG -> maxGroupSize.toString,
+
Review Comment:
well it was intentional because I added a comment above that applies to the
next 2 lines (so I added a newline before the comment and after the 2nd line).
Please take a look at the whole func block and let me know, happy to remove
both newlines if you think we don't really need them, was just to improve
readability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
