divijvaidya commented on code in PR #18638:
URL: https://github.com/apache/kafka/pull/18638#discussion_r1924246526
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##########
@@ -399,8 +399,8 @@ protected void safeForceUnmap() {
/**
* Forcefully free the buffer's mmap.
*/
- // Visible for testing, we can make this protected once OffsetIndexTest is
in the same package as this class
- public void forceUnmap() throws IOException {
+ // Made protected for the sake of visibility for testing.
Review Comment:
nit
we usually use `//visible for testing` comment for this in the code base.
But it's ok to do it this way as well in this PR. Doesn't matter as long as the
intent is conveyed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
