clolov commented on code in PR #18658:
URL: https://github.com/apache/kafka/pull/18658#discussion_r1925366015
##########
docs/zk2kraft.html:
##########
@@ -176,5 +176,16 @@ <h5 class="anchor-heading">Removal metrics</h5>
Kafka remove all zookeeper dependencies, so the metrics is
removed.
</p>
</li>
+ <li>
+ <p>
+ Remove the metrics which is monitoring requests waiting in the
topic purgatory
+ </p>
+ <ul>
+
<li><code>kafka.server:type=DelayedOperationPurgatory,name=PurgatorySize,delayedOperation=topic</code></li>
Review Comment:
I had a look at the `DelayedOperationPurgatory` class and I believe you are
actually removing 2 metrics instead of one
```
metricsGroup.newGauge("PurgatorySize", this::watched, metricsTags);
metricsGroup.newGauge("NumDelayedOperations", this::numDelayed, metricsTags);
```
Could you add this to the description as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
