ijuma commented on code in PR #18666:
URL: https://github.com/apache/kafka/pull/18666#discussion_r1925415870
##########
core/src/test/scala/kafka/server/LocalLeaderEndPointTest.scala:
##########
@@ -106,12 +125,11 @@ class LocalLeaderEndPointTest extends Logging {
.onFire(response => assertEquals(Errors.NONE, response.error))
assertEquals(new OffsetAndEpoch(0L, 0),
endPoint.fetchEarliestOffset(topicPartition, currentLeaderEpoch = 0))
- val leaderAndIsrRequest = buildLeaderAndIsrRequest(leaderEpoch = 4)
- replicaManager.becomeLeaderOrFollower(0, leaderAndIsrRequest, (_, _) => ())
+ bumpLeaderEpoch()
appendRecords(replicaManager, topicPartition, records)
.onFire(response => assertEquals(Errors.NONE, response.error))
replicaManager.deleteRecords(timeout = 1000L, Map(topicPartition -> 3), _
=> ())
- assertEquals(new OffsetAndEpoch(3L, 4),
endPoint.fetchEarliestOffset(topicPartition, currentLeaderEpoch = 7))
+ assertEquals(new OffsetAndEpoch(3L, 1),
endPoint.fetchEarliestOffset(topicPartition, currentLeaderEpoch = 7))
Review Comment:
Does the assert change because we don't have the ability to pick the epoch
in the same way with kraft?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
