frankvicky commented on PR #18590: URL: https://github.com/apache/kafka/pull/18590#issuecomment-2607580841
Hi @kirktrue, Thanks for the review. It's tricky to have `NetworkClientDelegate` ignore the `FindCoordinatorRequest` since the request is stored in `NetworkClient#inFlightRequests`, and we shouldn't manipulate this property outside of `NetworkClient`. I considered calling `completeExceptionally` on the in-flight `FindCoordinatorRequest` when closing, but I don't see any existing logic that does this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
