bbejeck commented on code in PR #18292:
URL: https://github.com/apache/kafka/pull/18292#discussion_r1925933969
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java:
##########
@@ -209,13 +209,14 @@ public void process(final Record<KIn, VIn> record) {
// (instead of `RuntimeException`) to work well with those
languages
final ErrorHandlerContext errorHandlerContext = new
DefaultErrorHandlerContext(
null, // only required to pass for
DeserializationExceptionHandler
- internalProcessorContext.topic(),
- internalProcessorContext.partition(),
- internalProcessorContext.offset(),
- internalProcessorContext.headers(),
+ internalProcessorContext.recordContext().topic(),
Review Comment:
Is there ever any chance `recordContext()` could return null?
We don't have to address this now, more just asking the question in general
##########
streams/src/main/java/org/apache/kafka/streams/errors/LogAndContinueExceptionHandler.java:
##########
@@ -40,7 +40,7 @@ public DeserializationHandlerResponse handle(final
ProcessorContext context,
log.warn(
"Exception caught during Deserialization, taskId: {}, topic: {},
partition: {}, offset: {}",
- context.taskId(),
+// context.taskId(),
Review Comment:
Why not just delete this? Same for below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
