chia7712 commented on code in PR #18654:
URL: https://github.com/apache/kafka/pull/18654#discussion_r1928469822
##########
docs/zk2kraft.html:
##########
@@ -155,44 +155,49 @@ <h5 class="anchor-heading">Removal metrics</h5>
</li>
<li>
<p>
- Remove the metrics which is monitoring the latency in
milliseconds for ZooKeeper requests from broker.
+ Remove the metrics which are only used in ZooKeeper mode.
</p>
<ul>
<li><code>kafka.server:type=ZooKeeperClientMetrics,name=ZooKeeperRequestLatencyMs</code></li>
- </ul>
- <p>
- In Kraft mode, Zookeeper is not used, so the metrics is
removed.
- </p>
- </li>
- <li>
- <p>
- Remove the metrics which is monitoring the number of Zookeeper
migrations.
- </p>
- <ul>
+
<li><code>kafka.controller:type=ControllerChannelManager,name=QueueSize</code></li>
+
<li><code>kafka.controller:type=ControllerChannelManager,name=RequestRateAndQueueTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerEventManager,name=EventQueueTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerEventManager,name=EventQueueSize</code></li>
+
<li><code>kafka.controller:type=KafkaController,name=ActiveControllerCount</code></li>
+
<li><code>kafka.controller:type=KafkaController,name=OfflinePartitionsCount</code></li>
+
<li><code>kafka.controller:type=KafkaController,name=PreferredReplicaImbalanceCount</code></li>
+
<li><code>kafka.controller:type=KafkaController,name=ControllerState</code></li>
+
<li><code>kafka.controller:type=KafkaController,name=GlobalTopicCount</code></li>
+
<li><code>kafka.controller:type=KafkaController,name=GlobalPartitionCount</code></li>
+
<li><code>kafka.controller:type=KafkaController,name=TopicsToDeleteCount</code></li>
+
<li><code>kafka.controller:type=KafkaController,name=ReplicasToDeleteCount</code></li>
+
<li><code>kafka.controller:type=KafkaController,name=TopicsIneligibleToDeleteCount</code></li>
+
<li><code>kafka.controller:type=KafkaController,name=ReplicasIneligibleToDeleteCount</code></li>
+
<li><code>kafka.controller:type=KafkaController,name=ActiveBrokerCount</code></li>
+
<li><code>kafka.controller:type=KafkaController,name=FencedBrokerCount</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=UncleanLeaderElectionsPerSec</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=IdleRateAndTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=ControllerChangeRateAndTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=LeaderElectionRateAndTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=TopicChangeRateAndTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=TopicDeletionRateAndTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=PartitionReassignmentRateAndTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=AutoLeaderBalanceRateAndTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=ManualLeaderBalanceRateAndTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=ControlledShutdownRateAndTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=IsrChangeRateAndTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=LeaderAndIsrResponseReceivedRateAndTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=LogDirChangeRateAndTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=ControllerShutdownRateAndTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=UncleanLeaderElectionEnableRateAndTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=TopicUncleanLeaderElectionEnableRateAndTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=ListPartitionReassignmentRateAndTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=UpdateMetadataResponseReceivedRateAndTimeMs</code></li>
+
<li><code>kafka.controller:type=ControllerStats,name=UpdateFeaturesRateAndTimeMs</code></li>
<li><code>kafka.controller:type=KafkaController,name=MigratingZkBrokerCount</code></li>
<li><code>kafka.controller:type=KafkaController,name=ZkMigrationState</code></li>
- </ul>
- <p>
- Kafka remove all zookeeper dependencies, so the metrics is
removed.
- </p>
- </li>
- <li>
- <p>
- Remove the metrics which is monitoring requests waiting in the
topic purgatory
- </p>
- <ul>
<li><code>kafka.server:type=DelayedOperationPurgatory,name=PurgatorySize,delayedOperation=topic</code></li>
Review Comment:
Could you please align the order of attributes?
`type`,`delayedOperation`,`name` WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
