chia7712 commented on code in PR #18644:
URL: https://github.com/apache/kafka/pull/18644#discussion_r1929581753
##########
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##########
@@ -1051,9 +1051,9 @@ private void
handleApiVersionsResponse(List<ClientResponse> responses,
apiVersionsResponse.data().finalizedFeaturesEpoch());
apiVersions.update(node, nodeVersionInfo);
this.connectionStates.ready(node);
- log.debug("Node {} has finalized features epoch: {}, finalized
features: {}, supported features: {}, ZK migration ready: {}, API versions:
{}.",
+ log.debug("Node {} has finalized features epoch: {}, finalized
features: {}, supported features: {}, API versions: {}.",
node, apiVersionsResponse.data().finalizedFeaturesEpoch(),
apiVersionsResponse.data().finalizedFeatures(),
- apiVersionsResponse.data().supportedFeatures(),
apiVersionsResponse.data().zkMigrationReady(), nodeVersionInfo);
Review Comment:
> we can set the max versions to v4
Pardon me, it seems to me the max version is already set to v4
(`ApiKeys.API_VERSIONS.latestVersion()`). Please correct me if I misunderstand
anything.
> we might consider keeping it around so that 4.0+ controllers can reject
errant registrations from a Zk broker (like due to a misconfiguration).
it seems that is addressed already.
https://github.com/apache/kafka/blob/be7415cb8bf5e09ad969cccfcbffd30fd68804ea/metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java#L362
> remove the usages in the non-generated code.
I prefer to remove `isMigratingZkBroker` and `IsMigratingZkBroker` from
non-generated code. similar to my previous comment
https://github.com/apache/kafka/pull/17293#discussion_r1781513673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
