adixitconfluent commented on code in PR #18696:
URL: https://github.com/apache/kafka/pull/18696#discussion_r1930529093
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -462,6 +474,10 @@ public CompletableFuture<Void> maybeInitialize() {
// in the cached state are not missed
findNextFetchOffset.set(true);
endOffset =
cachedState.lastEntry().getValue().lastOffset();
+ // initialReadGapOffset is not required, if there are no
gaps in the read state response
+ if (isGapPresentInStateBatches) {
+ initialReadGapOffset = new
InitialReadGapOffset(endOffset, startOffset);
Review Comment:
I tried experimenting with some code changes, it looks like the code change
required to achieve this is much more complex, and given that the
initialization is quite a rare event (only on server start/restarts) and the
optimization offered by the new approach is not high (since it only covers a
subset of cases), I don't think its worth the effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
