apoorvmittal10 commented on code in PR #18671:
URL: https://github.com/apache/kafka/pull/18671#discussion_r1931799235
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -3185,9 +3187,87 @@ class KafkaApis(val requestChannel: RequestChannel,
def handleDescribeShareGroupOffsetsRequest(request: RequestChannel.Request):
Unit = {
val describeShareGroupOffsetsRequest =
request.body[DescribeShareGroupOffsetsRequest]
- // TODO: Implement the DescribeShareGroupOffsetsRequest handling
- requestHelper.sendMaybeThrottle(request,
describeShareGroupOffsetsRequest.getErrorResponse(Errors.UNSUPPORTED_VERSION.exception))
- CompletableFuture.completedFuture[Unit](())
+
+ if (!isShareGroupProtocolEnabled) {
+ requestHelper.sendMaybeThrottle(request,
describeShareGroupOffsetsRequest.getErrorResponse(Errors.UNSUPPORTED_VERSION.exception))
+ CompletableFuture.completedFuture[Unit](())
+ } else if (!authHelper.authorize(request.context, READ, GROUP,
describeShareGroupOffsetsRequest.data.groupId)) {
+ requestHelper.sendMaybeThrottle(request,
describeShareGroupOffsetsRequest.getErrorResponse(Errors.GROUP_AUTHORIZATION_FAILED.exception))
+ CompletableFuture.completedFuture[Unit](())
+ } else {
+ val topicNamesToIds = metadataCache.topicNamesToIds()
+ val topicIdToNames = metadataCache.topicIdsToNames()
+
+ val readStateSummaryData =
getReadShareGroupStateSummaryRequestFromDescribeShareGroupOffsetsRequest(
+ describeShareGroupOffsetsRequest.data(),
+ topicNamesToIds
+ )
+ groupCoordinator.describeShareGroupOffsets(
+ request.context,
+ readStateSummaryData,
+ ).handle[Unit] { (response, exception) =>
+ if (exception != null) {
+ requestHelper.sendMaybeThrottle(request,
describeShareGroupOffsetsRequest.getErrorResponse(exception))
+ } else {
+ requestHelper.sendMaybeThrottle(
+ request,
+ new DescribeShareGroupOffsetsResponse(
+
getDescribeShareGroupOffsetsResponseFromReadShareGroupStateSummaryResponse(response,
topicIdToNames)
+ )
+ )
+ }
+ }
+ }
+ }
+
+ private def
getReadShareGroupStateSummaryRequestFromDescribeShareGroupOffsetsRequest(describeShareGroupOffsetsRequestData:
DescribeShareGroupOffsetsRequestData,
+
topicNamesId: util.Map[String, Uuid]
+
): ReadShareGroupStateSummaryRequestData = {
+ val readStateSummaryTopics =
describeShareGroupOffsetsRequestData.topics.asScala.map(
+ topic => {
+ val partitions = topic.partitions.asScala.map(
+ partitionIndex => {
+ new PartitionData()
+ .setPartition(partitionIndex)
+ .setLeaderEpoch(0)
Review Comment:
Is it correct to default leader epoch to 0 always?
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -3185,9 +3187,87 @@ class KafkaApis(val requestChannel: RequestChannel,
def handleDescribeShareGroupOffsetsRequest(request: RequestChannel.Request):
Unit = {
val describeShareGroupOffsetsRequest =
request.body[DescribeShareGroupOffsetsRequest]
- // TODO: Implement the DescribeShareGroupOffsetsRequest handling
- requestHelper.sendMaybeThrottle(request,
describeShareGroupOffsetsRequest.getErrorResponse(Errors.UNSUPPORTED_VERSION.exception))
- CompletableFuture.completedFuture[Unit](())
+
+ if (!isShareGroupProtocolEnabled) {
+ requestHelper.sendMaybeThrottle(request,
describeShareGroupOffsetsRequest.getErrorResponse(Errors.UNSUPPORTED_VERSION.exception))
+ CompletableFuture.completedFuture[Unit](())
+ } else if (!authHelper.authorize(request.context, READ, GROUP,
describeShareGroupOffsetsRequest.data.groupId)) {
+ requestHelper.sendMaybeThrottle(request,
describeShareGroupOffsetsRequest.getErrorResponse(Errors.GROUP_AUTHORIZATION_FAILED.exception))
+ CompletableFuture.completedFuture[Unit](())
+ } else {
+ val topicNamesToIds = metadataCache.topicNamesToIds()
+ val topicIdToNames = metadataCache.topicIdsToNames()
+
+ val readStateSummaryData =
getReadShareGroupStateSummaryRequestFromDescribeShareGroupOffsetsRequest(
+ describeShareGroupOffsetsRequest.data(),
+ topicNamesToIds
+ )
+ groupCoordinator.describeShareGroupOffsets(
+ request.context,
+ readStateSummaryData,
+ ).handle[Unit] { (response, exception) =>
+ if (exception != null) {
+ requestHelper.sendMaybeThrottle(request,
describeShareGroupOffsetsRequest.getErrorResponse(exception))
+ } else {
+ requestHelper.sendMaybeThrottle(
+ request,
+ new DescribeShareGroupOffsetsResponse(
+
getDescribeShareGroupOffsetsResponseFromReadShareGroupStateSummaryResponse(response,
topicIdToNames)
+ )
+ )
+ }
+ }
+ }
+ }
+
+ private def
getReadShareGroupStateSummaryRequestFromDescribeShareGroupOffsetsRequest(describeShareGroupOffsetsRequestData:
DescribeShareGroupOffsetsRequestData,
+
topicNamesId: util.Map[String, Uuid]
+
): ReadShareGroupStateSummaryRequestData = {
+ val readStateSummaryTopics =
describeShareGroupOffsetsRequestData.topics.asScala.map(
+ topic => {
+ val partitions = topic.partitions.asScala.map(
+ partitionIndex => {
+ new PartitionData()
+ .setPartition(partitionIndex)
+ .setLeaderEpoch(0)
+ }
+ ).asJava
+ new ReadStateSummaryData()
+ .setTopicId(topicNamesId.get(topic.topicName()))
+ .setPartitions(partitions)
+ }
+ ).asJava
Review Comment:
Hmmm, can't they be written as below, without conversions?
```
val readStateSummaryTopics =
describeShareGroupOffsetsRequestData.topics.stream.map(
topic => {
val partitions = topic.partitions.stream.map(
partitionIndex => {
new PartitionData()
.setPartition(partitionIndex)
.setLeaderEpoch(0)
}
).toList
new ReadStateSummaryData()
.setTopicId(topicNamesId.get(topic.topicName()))
.setPartitions(partitions)
}
).toList
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
