chia7712 commented on code in PR #18726:
URL: https://github.com/apache/kafka/pull/18726#discussion_r1933342089
##########
clients/src/main/resources/common/message/FetchResponse.json:
##########
@@ -106,7 +106,7 @@
]},
{ "name": "PreferredReadReplica", "type": "int32", "versions": "11+",
"default": "-1", "ignorable": false, "entityType": "brokerId",
"about": "The preferred read replica for the consumer to use on its
next fetch request."},
- { "name": "Records", "type": "records", "versions": "0+",
"nullableVersions": "0+", "about": "The record data."}
Review Comment:
> Please elaborate on the risk - what is the exact use case where that would
happen? I couldn't come up with one.
I believe `FetchResponse.json` should be considered part of the public
interface. Consequently, modifying the "released spec" carries inherent risks.
We cannot guarantee that no external implementations adhere to our
specification. For instance, other server implementations might return null
records, and after this PR, our 4.0 client would no longer be able to read them.
> Keep in mind that released versions of Kafka never return null records
that is true and it does not violate the spec, right? I mean "apache kafka
can never return null even though the spec says it is valid to return null"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
