lucasbru commented on code in PR #18703:
URL: https://github.com/apache/kafka/pull/18703#discussion_r1935613745
##########
streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java:
##########
@@ -62,92 +62,59 @@ public interface KStream<K, V> {
/**
* Create a new {@code KStream} that consists of all records of this
stream which satisfy the given predicate.
* All records that do not satisfy the predicate are dropped.
- * This is a stateless record-by-record operation.
+ * This is a stateless record-by-record operation (cf. {@link
#processValues(FixedKeyProcessorSupplier, String...)}
+ * for stateful record processing).
+ *
+ * @param predicate
+ * a filter {@link Predicate} that is applied to each record
+ *
+ * @return A {@code KStream} that contains only those records that satisfy
the given predicate.
Review Comment:
super-nit: I don't necessarily follow this myself (I typically have `@param`
and `@return` both start with a capital and end with a period), but the
official recommendation is to not capitalize and not follow with a period, as
it was before (
https://www.oracle.com/de/technical-resources/articles/java/javadoc-tool.html ).
Also, fun fact, there are people on github called `@param` and `@return`
that must be pinged all day in reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
