mingyen066 commented on code in PR #18767:
URL: https://github.com/apache/kafka/pull/18767#discussion_r1938449378
##########
clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java:
##########
@@ -96,6 +100,20 @@ public void
testParseAndValidateAddressesWithReverseLookup() {
}
}
+ static Stream<List<String>> provideBrokerListTestCases() {
+ return Stream.of(
+ Arrays.asList("localhost:9997", "localhost:9998",
"localhost:9999"),
+ // Intentionally provide a single string, as users may provide
space-separated brokers, which will be parsed as a single string.
+ Arrays.asList("localhost:9997 localhost:9998 localhost:9999")
Review Comment:
Unfortunately, List.of is a feature introduced in Java 9, which is not
supported by Kafka 3.9 (still built with Java 8).
##########
clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java:
##########
@@ -96,6 +100,20 @@ public void
testParseAndValidateAddressesWithReverseLookup() {
}
}
+ static Stream<List<String>> provideBrokerListTestCases() {
+ return Stream.of(
+ Arrays.asList("localhost:9997", "localhost:9998",
"localhost:9999"),
+ // Intentionally provide a single string, as users may provide
space-separated brokers, which will be parsed as a single string.
+ Arrays.asList("localhost:9997 localhost:9998 localhost:9999")
Review Comment:
Unfortunately, `List.of` is a feature introduced in Java 9, which is not
supported by Kafka 3.9 (still built with Java 8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
