lucasbru commented on code in PR #18676:
URL: https://github.com/apache/kafka/pull/18676#discussion_r1939456915
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/TargetAssignmentBuilder.java:
##########
@@ -265,12 +265,15 @@ public TargetAssignmentResult build() throws
TaskAssignorException {
// Compute the assignment.
GroupAssignment newGroupAssignment;
if (topology.isReady()) {
+ if (topology.subtopologies().isEmpty()) {
+ throw new IllegalStateException("Subtopologies must be present
if topology is ready.");
Review Comment:
Central check. This is implied by `isReady`, but I added the
`IllegalStateException` just in case some future updates breaks the internal
invariants of `ConfiguredTopology` (and to silence IDE warnings).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
