mumrah commented on PR #18770: URL: https://github.com/apache/kafka/pull/18770#issuecomment-2631350402
Thanks for taking a look everyone :) @junrao, the junit.py parsing will be included. The script needs to be modified a bit to handle the different test directories. I wanted to float this idea before fully making the change. The output will be similar to how it looks today. @chia7712 I'd like to avoid breaking compatibility with regular JUnit features like `@ParameterizedTest`. A cursory search shows a few usages beyond ZK/KRaft. With this change, PRs will have red builds if a single new test fails. Since PRs usually have a few builds along the way, maybe that gives us enough safety? At least it will be better than the current situation where a new test could fail 3 times and still get merged (if the author didn't check the test report) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
