chirag-wadhwa5 commented on code in PR #18696:
URL: https://github.com/apache/kafka/pull/18696#discussion_r1941067497
##########
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##########
@@ -5845,6 +7002,46 @@ public void testAcquireWithWriteShareGroupStateDelay() {
assertEquals(RecordState.ACQUIRED,
sharePartition.cachedState().get(10L).batchState());
}
+ @Test
+ public void testFindLastOffsetAcknowledgedWhenGapAtBeginning() {
Review Comment:
Thanks for the review. The test
`testMaybeUpdateCachedStateGapAfterLastOffsetAcknowledged` covers testing these
scenarios as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
