apoorvmittal10 commented on code in PR #18804:
URL: https://github.com/apache/kafka/pull/18804#discussion_r1941829163
##########
server/src/main/java/org/apache/kafka/server/share/fetch/ShareAcquiredRecords.java:
##########
@@ -60,13 +68,20 @@ public int count() {
return count;
}
+ public boolean subsetAcquired() {
+ return subsetAcquired;
+ }
+
public static ShareAcquiredRecords empty() {
return EMPTY_SHARE_ACQUIRED_RECORDS;
}
- public static ShareAcquiredRecords fromAcquiredRecords(AcquiredRecords
acquiredRecords) {
- return new ShareAcquiredRecords(
- List.of(acquiredRecords), (int) (acquiredRecords.lastOffset() -
acquiredRecords.firstOffset() + 1)
- );
+ @Override
+ public String toString() {
+ return "ShareAcquiredRecords (" +
+ "acquiredRecords=" + acquiredRecords +
Review Comment:
Removed the to string, not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
