[
https://issues.apache.org/jira/browse/KAFKA-18722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924061#comment-17924061
]
Christo Lolov commented on KAFKA-18722:
---------------------------------------
Reviewed and merged into trunk!
> Remove the unreferenced methods from TopicBasedRemoteLogMetadataManager
> -----------------------------------------------------------------------
>
> Key: KAFKA-18722
> URL: https://issues.apache.org/jira/browse/KAFKA-18722
> Project: Kafka
> Issue Type: Task
> Reporter: Kamal Chandraprakash
> Assignee: Kamal Chandraprakash
> Priority: Major
>
> The below methods are unused in TopicBasedRemoteLogMetadataManager,
> previously they were used in tests and tests have been removed:
> {noformat}
> public int metadataPartition(TopicIdPartition topicIdPartition) {
> return rlmTopicPartitioner.metadataPartition(topicIdPartition);
> }
> // Visible For Testing
> public Optional<Long> readOffsetForPartition(int metadataPartition) {
> return consumerManager.readOffsetForPartition(metadataPartition);
> } {noformat}
> See this comment:
> https://github.com/apache/kafka/pull/18787#pullrequestreview-2590172815
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
