cadonna commented on code in PR #18830:
URL: https://github.com/apache/kafka/pull/18830#discussion_r1946581634
##########
streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestDriver.java:
##########
@@ -184,6 +194,7 @@ public static Map<String, Set<Integer>> generate(final
String kafka,
final List<ProducerRecord<byte[], byte[]>> dataNeedRetry = new
ArrayList<>();
final List<ProducerRecord<byte[], byte[]>> fkNeedRetry = new
ArrayList<>();
+
Review Comment:
nit:
```suggestion
```
##########
streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestDriver.java:
##########
@@ -272,7 +287,6 @@ private static void flush(final KafkaProducer<byte[],
byte[]> producer,
producer.send(new ProducerRecord<>(
partition.topic(),
partition.partition(),
- System.currentTimeMillis() + Duration.ofDays(2).toMillis(),
Review Comment:
Could you put `System.currentTimeMillis()` so that I do not need to navigate
to the method to understand that the timestamp is set to
`System.currentTimeMillis()` by default? 🙂
##########
streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestDriver.java:
##########
@@ -207,6 +220,8 @@ public static Map<String, Set<Integer>> generate(final
String kafka,
final ProducerRecord<byte[], byte[]> fkRecord =
new ProducerRecord<>(
"fk",
+ null,
+ System.currentTimeMillis() - CREATE_TIME_SHIFT_MS,
Review Comment:
nit:
```suggestion
System.currentTimeMillis() -
CREATE_TIME_SHIFT_MS,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
