mjsax commented on code in PR #18840:
URL: https://github.com/apache/kafka/pull/18840#discussion_r1947484456
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -682,7 +682,7 @@ public class StreamsConfig extends AbstractConfig {
/** {@code processor.wrapper.class} */
public static final String PROCESSOR_WRAPPER_CLASS_CONFIG =
"processor.wrapper.class";
- public static final String PROCESSOR_WRAPPER_CLASS_DOC = "A processor
wrapper class or class name that implements the
<code>org.apache.kafka.streams.state.ProcessorWrapper</code> interface. "
+ static final String PROCESSOR_WRAPPER_CLASS_DOC = "A processor wrapper
class or class name that implements the
<code>org.apache.kafka.streams.state.ProcessorWrapper</code> interface. "
Review Comment:
This is the root cause for the PR. Saw this by chance...
KIP-1112 correctly declares it as `private` -- we need to make it
package-private though.,to allow `TopologyConfig` to use it. It should not be
public.
As it seems we keep leaking these members (and it could happen again in the
future), I added a test for it below (to avoid that we need to do another KIP
to remove it again in the future... cf
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1085%3A+Fix+leaking+*_DOC+variables+in+StreamsConfig)
Took the liberty to fix this in 4.0 directly:
https://github.com/apache/kafka/commit/562ecf4a83c2fa3577c45eba02328a1bfb751c2a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
