ijuma commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1950204878
##########
metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java:
##########
@@ -137,10 +137,10 @@ static ControllerResult<Void> recordsForNonEmptyLog(
}
}
- if (curMetadataVersion.equals(MetadataVersion.MINIMUM_KRAFT_VERSION)) {
+ if (curMetadataVersion.equals(MetadataVersion.MINIMUM_VERSION)) {
Review Comment:
Good catch. We have two options: (1) Remove this log or (2) Pass a parameter
indicating whether `metadata.version` feature level record is present. Do you
have an opinion on which way is better? I'll also take a closer look to
understand whether the second option is worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
