AndrewJSchofield commented on code in PR #18850:
URL: https://github.com/apache/kafka/pull/18850#discussion_r1950757501
##########
clients/src/main/java/org/apache/kafka/clients/consumer/GroupProtocol.java:
##########
@@ -23,7 +23,10 @@ public enum GroupProtocol {
CLASSIC("CLASSIC"),
/** Consumer group protocol */
- CONSUMER("CONSUMER");
+ CONSUMER("CONSUMER"),
+
+ /** Share group protocol */
+ SHARE("SHARE");
Review Comment:
I was not expecting `GroupProtocol.SHARE` to exist. By adding a third
enumeration constant, a bunch of tests which iterate over the group protocols
now need special code to avoid share groups. Doesn't seem ideal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
