mjsax commented on code in PR #18835:
URL: https://github.com/apache/kafka/pull/18835#discussion_r1953389302
##########
tests/kafkatest/tests/streams/streams_smoke_test.py:
##########
@@ -109,5 +109,7 @@ def test_streams(self, processing_guarantee, crash,
metadata_quorum):
if crash and processing_guarantee == 'at_least_once':
self.driver.node.account.ssh("grep -E
'SUCCESS|PROCESSED-MORE-THAN-GENERATED' %s" % self.driver.STDOUT_FILE,
allow_fail=False)
+ # fail if we find "missing result data" output in the stdout file;
while we can tolerate duplication, we cannot tolerate data loss
+ self.driver.node.account.ssh("[ ! `grep 'missing result data'" %
self.driver.STDOUT_FILE % "` ]", allow_fail=False)
else:
self.driver.node.account.ssh("grep SUCCESS %s" %
self.driver.STDOUT_FILE, allow_fail=False)
Review Comment:
Well, I guess, but we would need to reverse the logic an fail if we find
FAILURE.... Don't see what we would gain?
Atm, the test passes, if we can `grep SUCCESS` and automatically fail if
`grep` does not find it.
Would this be better? Personally I find it more complicated.
```
self.driver.node.account.ssh("[ ! `grep FAILURE %s" %
self.driver.STDOUT_FILE % "` ]", allow_fail=False)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
