mjsax commented on code in PR #18880:
URL: https://github.com/apache/kafka/pull/18880#discussion_r1953765083
##########
docs/design.html:
##########
@@ -385,8 +385,10 @@ <h3 class="anchor-heading"><a id="replication"
class="anchor-link"></a><a href="
have the option of either waiting for the message to be committed or not,
depending on their preference for tradeoff between latency and durability. This
preference is controlled by the acks setting that the
producer uses.
Note that topics have a setting for the "minimum number" of in-sync
replicas that is checked when the producer requests acknowledgment that a
message
Review Comment:
```suggestion
Note that topics have a setting for the minimum number of in-sync
replicas (<code>min.insync.replicas</code>) that is checked when the producer
requests acknowledgment that a message
```
##########
docs/design.html:
##########
@@ -385,8 +385,10 @@ <h3 class="anchor-heading"><a id="replication"
class="anchor-link"></a><a href="
have the option of either waiting for the message to be committed or not,
depending on their preference for tradeoff between latency and durability. This
preference is controlled by the acks setting that the
producer uses.
Note that topics have a setting for the "minimum number" of in-sync
replicas that is checked when the producer requests acknowledgment that a
message
- has been written to the full set of in-sync replicas. If a less stringent
acknowledgement is requested by the producer, then the message can be
committed, and consumed,
- even if the number of in-sync replicas is lower than the minimum (e.g. it
can be as low as just the leader).
+ has been written to the full set of in-sync replicas. If a less stringent
acknowledgment is requested by the producer, then the message can be committed
earlier and easier.
+ In both cases, the messages will not be visible to the consumers until all
the following conditions are met:
+ 1. The messages are replicated to all the in-sync replicas.
+ 2. The number of the in-sync replicas is no less than the "minimum number"
setting.
Review Comment:
This need to be proper HTML markup:
```
<ol>
<li>The messages are replicated to all the in-sync replicas.</li>
<li>The number of the in-sync replicas is no less than the "minimum
number" setting.</li>
</ol>
```
Also `no less than the "minimum number" setting` -> `no less than the
<code>min.insync.replicas</code> setting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
