AndrewJSchofield commented on code in PR #18819: URL: https://github.com/apache/kafka/pull/18819#discussion_r1954104535
########## clients/src/main/java/org/apache/kafka/common/requests/AlterShareGroupOffsetsRequest.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.common.requests; + +import org.apache.kafka.common.message.AlterShareGroupOffsetsRequestData; +import org.apache.kafka.common.message.AlterShareGroupOffsetsResponseData; +import org.apache.kafka.common.protocol.ApiKeys; +import org.apache.kafka.common.protocol.ByteBufferAccessor; +import org.apache.kafka.common.protocol.Errors; + +import java.nio.ByteBuffer; +import java.util.ArrayList; +import java.util.List; +import java.util.stream.Collectors; + +public class AlterShareGroupOffsetsRequest extends AbstractRequest { + + private final AlterShareGroupOffsetsRequestData data; + + public AlterShareGroupOffsetsRequest(AlterShareGroupOffsetsRequestData data, short version) { + super(ApiKeys.ALTER_SHARE_GROUP_OFFSETS, version); + this.data = data; + } + + public static class Builder extends AbstractRequest.Builder<AlterShareGroupOffsetsRequest> { + + private final AlterShareGroupOffsetsRequestData data; + + public Builder(AlterShareGroupOffsetsRequestData data) { + this(data, true); Review Comment: I agree. Because these APIs are marked as unstable in the JSON request schema, a broker will only offer them if unstable APIs are enabled. That is independent of whether the code which constructs the request needs to explicitly specify that it wants an unstable last version. So, I'm happy with the code like this. The plan for 4.1 is that all of these APIs become stable and that KIP-932 is enabled using a combination of features and configurations. I'm not planning to take that step until all of the admin JIRAs have been implemented. Good progress is being made on these. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
