leaf-soba commented on PR #18868: URL: https://github.com/apache/kafka/pull/18868#issuecomment-2658420820
> Note that these methods are not the same, `toList` results in an immutable list. I tried this before and it caused a few tests to fail, so we need to be careful when making this change. > > The hard part is validating the cases where the tests do _not_ fail (as there could be missing coverage). @ijuma Thanks for the note! I agree that this PR involves a large change with high risks and minimal benefits to the project. Given the potential issues, I think it would be better to close this PR and create a smaller one that focuses on other refactoring tasks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
