apoorvmittal10 commented on code in PR #18877:
URL: https://github.com/apache/kafka/pull/18877#discussion_r1955748755
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamSelfJoin.java:
##########
@@ -99,9 +99,9 @@ public void process(final Record<K, V1> record) {
long timeFrom = Math.max(0L, inputRecordTimestamp -
joinThisBeforeMs);
long timeTo = Math.max(0L, inputRecordTimestamp + joinThisAfterMs);
boolean emittedJoinWithSelf = false;
- final Record selfRecord = record
- .withValue(joinerThis.apply(record.key(), record.value(), (V2)
record.value()))
- .withTimestamp(inputRecordTimestamp);
+ Record<K, VOut> selfRecord = record
+ .withValue(joinerThis.apply(record.key(), record.value(), (V2)
record.value()));
+ selfRecord = selfRecord.withTimestamp(inputRecordTimestamp);
Review Comment:
Will it not be appropraite to write?
```
final Record<K, ? extends VOut> selfRecord = record
.withValue(joinerThis.apply(record.key(), record.value(), (V2)
record.value()))
.withTimestamp(inputRecordTimestamp);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
