adixitconfluent commented on PR #18864: URL: https://github.com/apache/kafka/pull/18864#issuecomment-2659266502
I have amended the implementation of the **step 3** of the assignment such that we will combine new and current assignment without revoking the assignments that were assigned by step 1 in the new assignment and have members in current assignment by step 2. This has been done to avoid the complexity in both the implementation and the run time complexity because as of now we can only get the current assignment while calculating the new assignment. We do not have a way to know with which step, a particular assignment happened in the current assignment. I do have a way with which we can recreate the step wise assignment using the current assignment but that involves sorting and unnecessary computation. Hence, I am deferring with that approach. IMO, **step 3** helps in reducing the burden of certain members of the share groups. This can be achieved with the help of limiting the max no. of partitions assignment for every member([KAFKA-18788](https://issues.apache.org/jira/browse/KAFKA-18788)). Hence, the potential problem of burdening the share consumers will be addressed in a future PR. PS - We shouldn't have any problem in merging the PR to trunk with the amendment I suggested since right now, we anyways assign all the topic partitions to all the share group members which would be leading to burdening the share consumers anyways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
