Yunyung commented on PR #18916: URL: https://github.com/apache/kafka/pull/18916#issuecomment-2661447763
> 1. Manually test this patch by creating some ACLs and showing the output from metadata shell Before: ``` $ ./bin/kafka-metadata-shell.sh --snapshot /tmp/kraft-combined-logs/__cluster_metadata-0/00000000000000000000.log Loading... [2025-02-16 13:58:14,107] ERROR Ignoring control record with type KRAFT_VERSION at offset 1 (org.apache.kafka.metadata.util.SnapshotFileReader) [2025-02-16 13:58:14,110] ERROR Ignoring control record with type KRAFT_VOTERS at offset 2 (org.apache.kafka.metadata.util.SnapshotFileReader) Starting... [ Kafka Metadata Shell ] >> ls image/acls/ 5Mu_djJ5QZaw79Fc3URLfw >> ``` After: ``` $ ./bin/kafka-metadata-shell.sh --snapshot /tmp/kraft-combined-logs/__cluster_metadata-0/00000000000000000000.log Loading... [2025-02-16 21:59:06,250] ERROR Ignoring control record with type KRAFT_VERSION at offset 1 (org.apache.kafka.metadata.util.SnapshotFileReader) [2025-02-16 21:59:06,251] ERROR Ignoring control record with type KRAFT_VOTERS at offset 2 (org.apache.kafka.metadata.util.SnapshotFileReader) Starting... [ Kafka Metadata Shell ] >> ls image/acls/ byId >> ls image/acls/byId/ cnTIY8C5R5-PIm0EKywItg >> ``` > 2. Add a unit test for the MetadataImageNode to ensure we see the "acls" node correctly Done. Thanks for the review, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
